Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sem): analysis considers nested noreturn #1450

Merged
merged 5 commits into from
Sep 7, 2024
Merged

fix(sem): analysis considers nested noreturn #1450

merged 5 commits into from
Sep 7, 2024

Commits on Sep 6, 2024

  1. noreturn analysis accounts for if/case/try/block

    @saem
    saem committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    2b71e2a View commit details
    Browse the repository at this point in the history

  2. fix bad formatting, it was really annoying

    @saem
    saem committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    85714b5 View commit details
    Browse the repository at this point in the history

  3. complete doc comment

    @saem
    saem authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ea2e101 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Apply suggestions from code review 

    - quoting test description used double quotes, need triple-double-quotes
  - surfaced a testament bug that silently ignores error on test joining
- fix nested `case` test
- clean-up `endsInNoReturn` docs
- fix nested checking, both checking `.typ` field with `isEmptyType` and focus on stmt variants of nodes

Co-authored-by: zerbina <[email protected]>
    @saem @zerbina
    saem and zerbina authored Sep 7, 2024
    Configuration menu
    Copy the full SHA
    e3b6fa2 View commit details
    Browse the repository at this point in the history

  2. Update tests/lang_exprs/tnoreturn_nested.nim 

    Co-authored-by: zerbina <[email protected]>
    @saem @zerbina
    saem and zerbina authored Sep 7, 2024
    Configuration menu
    Copy the full SHA
    f0f5360 View commit details
    Browse the repository at this point in the history