-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sem): analysis considers nested noreturn #1450
Merged
chore-runner
merged 5 commits into
nim-works:devel
from
saem:saem-move-and-fix-endsInNoReturn
Sep 7, 2024
Merged
fix(sem): analysis considers nested noreturn #1450
chore-runner
merged 5 commits into
nim-works:devel
from
saem:saem-move-and-fix-endsInNoReturn
Sep 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saem
added
bug
Something isn't working
compiler/sem
Related to semantic-analysis system of the compiler
labels
Sep 6, 2024
saem
changed the title
Saem move and fix ends in no return
fix(sem): analysis considers nested noreturns
Sep 6, 2024
saem
commented
Sep 6, 2024
zerbina
reviewed
Sep 7, 2024
saem
commented
Sep 7, 2024
- quoting test description used double quotes, need triple-double-quotes - surfaced a testament bug that silently ignores error on test joining - fix nested `case` test - clean-up `endsInNoReturn` docs - fix nested checking, both checking `.typ` field with `isEmptyType` and focus on stmt variants of nodes Co-authored-by: zerbina <[email protected]>
zerbina
reviewed
Sep 7, 2024
Co-authored-by: zerbina <[email protected]>
saem
changed the title
fix(sem): analysis considers nested noreturns
fix(sem): analysis considers nested noreturn
Sep 7, 2024
/merge |
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
No-return analysis ensures that nested final expressions (
block/case/if/try
) are accounted for no-return itself.Details
Prior to this change if the last expression within a greater expression
was a no-return expression it would not be deemed as such if it was a
block/case/if/try
, instead errors would be raised related to discardchecks or that path not resulting in the correct type.
For example, the following would result in an error where
0
must beused or discarded:
Fixes #1440