Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting download dir name for develop #952

Merged
merged 3 commits into from
Dec 3, 2021

Commits on Oct 11, 2021

  1. Fix getting download dir name for develop

    When getting the download directory name for a package that we want to
    put in develop mode, a trailing slash in the URL or the subdir leads to
    getting an empty string. To fix the problem we remove the trailing slash
    from them at the start of the `getDevelopDownloadDir` procedure.
    bobeff committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    817587c View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. Add tests for the getDevelopDownloadDir proc

    The `getDevelopDownloadDir` procedure is moved in the `download.nim`
    module and units tests for it are added.
    bobeff committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    6cbc0c4 View commit details
    Browse the repository at this point in the history
  2. Fix the tests on Windows

    Fix the `getDevelopDownloadDir` procedure tests on Windows by adding
    normalization of the expected paths.
    bobeff committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    3c16ad0 View commit details
    Browse the repository at this point in the history