Fix getting download dir name for develop #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting the download directory name for a package that we want to put in develop mode, a trailing slash in the URL or the subdir leads to getting an empty string. To fix the problem we remove the trailing slash from them at the start of the `getDevelopDownloadDir` procedure.
dom96
approved these changes
Nov 5, 2021
The `getDevelopDownloadDir` procedure is moved in the `download.nim` module and units tests for it are added.
Fix the `getDevelopDownloadDir` procedure tests on Windows by adding normalization of the expected paths.
@dom96 Done. |
CyberTailor
pushed a commit
to CyberTailor/nimble
that referenced
this pull request
Dec 12, 2021
* Fix getting download dir name for develop When getting the download directory name for a package that we want to put in develop mode, a trailing slash in the URL or the subdir leads to getting an empty string. To fix the problem we remove the trailing slash from them at the start of the `getDevelopDownloadDir` procedure. * Add tests for the `getDevelopDownloadDir` proc The `getDevelopDownloadDir` procedure is moved in the `download.nim` module and units tests for it are added. * Fix the tests on Windows Fix the `getDevelopDownloadDir` procedure tests on Windows by adding normalization of the expected paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting the download directory name for a package that we want to put in develop mode, a trailing slash in the URL or the subdir leads to getting an empty string. To fix the problem we remove the trailing slash from them at the start of the
getDevelopDownloadDirprocedure.