Update and improve PCRE wrapper #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Version 8.36 (was 8.31) - Support for editable functions - Name arguments according to docs - Cosmetics
| # that is triggered by the (?) regex item. For Virtual Pascal, these definitions | ||
| # have to take another form. | ||
| var | ||
| pcre_malloc*: proc (a: csize): pointer {.cdecl.} |
There was a problem hiding this comment.
This cannot work! It's not imported nor should it be. Remove the whole 'var' section please.
|
Oh, what about |
|
pure, final are not necessary anymore. |
|
I think the pull request is ready. |
| JitCallback* = proc (a: pointer): ptr JitStack {.cdecl.} | ||
|
|
||
|
|
||
| when not defined(pcreDll): |
|
Changed to (And accidentally closed the pull request 😢) |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for editable functionsIt is largely backwards-compatible (re module keeps working, with some deprecation warnings, which I fixed in the 2nd commit), but some differences are present (e.g. there is an argument
ptr cucharpointerthat used to becstring).All tests of re pass. I also tried these changes on my library that uses re, and all its tests passed.
I based this work on @flaviut's PCRE wrapper.