Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and replace 're' with 'nre' #2511

Closed
12 tasks done
oprypin opened this issue Apr 10, 2015 · 3 comments · Fixed by #2818
Closed
12 tasks done

Deprecate and replace 're' with 'nre' #2511

oprypin opened this issue Apr 10, 2015 · 3 comments · Fixed by #2818

Comments

@oprypin
Copy link
Contributor

oprypin commented Apr 10, 2015

Nim's regular expression library (re) has many problems.

  • Broken behavior
  • Not supported:
  • Limited to 20 captures
  • Unintuitive API
    • Many functions that do almost the same thing but differently
    • Requires passing a pre-populated var argument
    • Two flags are on by default, so if you want to add one more you must specify three flags manually.

Many people report problems chaotically in different places, some do pull requests, sometimes changing from a broken behavior to a wrong behavior, sometimes adding more procedures, making the API more confusing. This has gone on for too long.

There is a new library, nre. It solves pretty much all of the problems mentioned above. It is very polished and thoroughly tested for all corner cases. It has a consistent, concise but richer API.

I suggest to include nre in the standard library.

Steps towards implementing this:

After 0.11.2 release:

@dom96 dom96 added the RFC label Apr 10, 2015
@dom96
Copy link
Contributor

dom96 commented Apr 10, 2015

Relevant discussion on IRC from about 6pm onwards: http://irclogs.nim-lang.org/10-04-2015.html

@Araq
Copy link
Member

Araq commented Apr 14, 2015

Well I need to review these patches and test them still, but apart from that it's all fine with me.

@flaviut
Copy link
Contributor

flaviut commented May 12, 2015

Blocked on #2515.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants