This repository has been archived by the owner on Feb 27, 2019. It is now read-only.
Removed HK #98
Closed
Removed HK #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was the dispatch_group_notify stuff specifically for HealthKit? |
|
I added it for cloud kit but there's no need for it since we are going to set a pending status until onAuthChange is triggered |
|
I was seeing some weirdness with notifications on this PR (approving the permission and then having it show as "denied" briefly) so I isolated the changes a bit more in 8c92068. I'd still like to see the style changes included here in a PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Fixes" #97