Skip to content
This repository has been archived by the owner on Feb 27, 2019. It is now read-only.

Optional import of Healtkit #97

Closed
felix-dumit opened this issue Sep 19, 2015 · 12 comments
Closed

Optional import of Healtkit #97

felix-dumit opened this issue Sep 19, 2015 · 12 comments
Labels

Comments

@felix-dumit
Copy link
Contributor

I submitted my app to the appstore but it was rejected with the following:

"27.6 - Apps using the HealthKit framework must indicate integration with the Health app in their marketing text and must clearly identify the HealthKit functionality in the app's user interface"

I'm not using Healthkit anywhere in my code so it must be due to PermissionScope.
So we need a way to make HealthKit optional, maybe in a subspec.

@bre7
Copy link
Collaborator

bre7 commented Sep 19, 2015

Ahh :( yeah, sub-specs seem to be the way to go. What about Carthage ? New xcodeproj per subspec ?

@nickoneill
Copy link
Owner

I was just approved for beta testing with the newest pscope code - afaik they want you to adhere to the guidelines for testflight as well as releases and this feels like something they would detect automatically. Are you sure it's not something else? An errant healthkit entitlement?

@bre7 bre7 added the bug label Sep 19, 2015
@bre7
Copy link
Collaborator

bre7 commented Sep 19, 2015

HK capability is off right ?

@felix-dumit
Copy link
Contributor Author

The app was approved for test flight beta, but rejected for the store.
I have not enabled health kit in capabilities.

@nickoneill
Copy link
Owner

Ah, OK. Thanks for the tip. I'll work on this today.

@gloparco
Copy link

In general this would be a good thing anyway - if your app doesn't use HealthKit, why should you be forced to include it? Makes sense, no?

@bre7
Copy link
Collaborator

bre7 commented Sep 20, 2015

Yeah ;)

Remove HK for now and push 0.9.1 ? (Remove the GCD code using groups, there's no need for that since we are going to add the Pending status)

@nickoneill
Copy link
Owner

The healthkit stuff is so unpolished right now, I feel OK with removing it from a 1.0.1 release @bre7.

@gloparco If you don't ask for them, permissionscope doesn't load or call any HealthKit APIs. It's possible that the import statement was linking the HealthKit framework through. Definitely a good reason to split stuff into files/subspecs.

@bre7 bre7 mentioned this issue Sep 20, 2015
@nickoneill
Copy link
Owner

Please give 1.0.1 a shot with this. I've removed all mentions of HealthKit and we'll work it back in via subspec soon.

@felix-dumit
Copy link
Contributor Author

I resubmitted. Will let you know the outcome

@felix-dumit
Copy link
Contributor Author

Update here: The app was still rejected and I'm appealing (been a month already 😞) but it had nothing to do with HealthKit so we're good.

@bre7 bre7 closed this as completed Oct 20, 2015
@bre7
Copy link
Collaborator

bre7 commented Oct 20, 2015

Reopen the issue if the rejection turns out to be due to PScope

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants