fix(store): initial state should not be overwritten by defaults #904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #902
There was a regression caused by PR #791 in this line:
https://github.com/ngxs/store/pull/791/files#diff-084c7b85b6562e3126b58451d5f8943aR20
This only affects Emitter plugin users. This is because of the way that Emitter inherits from Store to create an EmitStore. I found the point at which the state was being overwritten. See this stackblitz:
https://stackblitz.com/edit/ngxs-no-initial-state-debug
Ngxs does not expect a plugin to inherit from Store and essentially run this code twice. Emitter does some things with Ngxs internals that are not usual plugin behaviours.
What is the new behavior?
This code is now protected from being run twice. The default values are only written into the store if there is no current value in the store.
Does this PR introduce a breaking change?