Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): reusable states #791

Merged
merged 7 commits into from
Jan 28, 2019
Merged

feat(store): reusable states #791

merged 7 commits into from
Jan 28, 2019

Conversation

splincode
Copy link
Member

@splincode splincode commented Jan 25, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number:
#179
#741
#719

What is the new behavior?

throw an error, since the previous state will be overwritten

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@splincode
Copy link
Member Author

splincode commented Jan 26, 2019 •
edited
Loading

@markwhitfeld ping

markwhitfeld
markwhitfeld reviewed Jan 27, 2019
View reviewed changes
tsconfig.json Outdated Show resolved Hide resolved
@splincode splincode changed the title fix(store): throw an error if the state name is not unique feat(store): reusable states Jan 27, 2019
@splincode splincode removed the request for review from eranshmil January 27, 2019 07:12
@splincode
Copy link
Member Author

@markwhitfeld @arturovt I have improved the formation of the state tree so that the hmr-plugin will now work perfectly

markwhitfeld
markwhitfeld requested changes Jan 27, 2019
View reviewed changes
Copy link
Member

@markwhitfeld markwhitfeld left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I identified some issues and had quite a few things that I wanted tweaked so I decided to make the changes to the branch directly.
@splincode please check my changes to see if you are ok with them.
You can check some of my resolved comments below for context.

packages/store/src/internal/state-factory.ts Outdated Show resolved Hide resolved
packages/store/src/internal/state-factory.ts Outdated Show resolved Hide resolved
packages/store/src/internal/state-factory.ts Outdated Show resolved Hide resolved
packages/store/src/symbols.ts Outdated Show resolved Hide resolved
packages/store/src/utils/store-validators.ts Outdated Show resolved Hide resolved
packages/store/src/internal/state-factory.ts Outdated Show resolved Hide resolved
packages/store/src/internal/state-factory.ts Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
markwhitfeld
markwhitfeld approved these changes Jan 27, 2019
View reviewed changes
Copy link
Member

@markwhitfeld markwhitfeld left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy now after my changes ;-)

@splincode
Copy link
Member Author

@markwhitfeld it's awesome

@markwhitfeld markwhitfeld merged commit 1aa2d3f into master Jan 28, 2019
@markwhitfeld markwhitfeld deleted the feature/states-exclude branch February 2, 2019 03:35
This was referenced Mar 7, 2019
Closed
Merged
@KorsaR-ZN KorsaR-ZN mentioned this pull request Jun 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturovt arturovt arturovt approved these changes

@markwhitfeld markwhitfeld markwhitfeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@splincode @markwhitfeld @arturovt