feat: add support for RxJS 7.x #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
commented
Aug 6, 2021
brandonroberts
requested review from
timdeschryver,
alex-okrushko and
markostanimirovic
|
Preview docs changes for f8cb134 at https://previews.ngrx.io/pr3109-f8cb1340/ |
|
Up :) We waiting :) |
brandonroberts
force-pushed
the
rxjs7
branch
from
4d38412 to
aa40743
Compare
3 tasks
brandonroberts
force-pushed
the
rxjs7
branch
from
aa40743 to
52ae90e
Compare
brandonroberts
force-pushed
the
rxjs7
branch
2 times, most recently
from
ef830e7 to
c3e8d0e
Compare
brandonroberts
changed the title
timdeschryver
approved these changes
Oct 14, 2021
package.json
Outdated
| @@ -222,7 +222,8 @@ | |||
| "listr": "^0.14.2", | |||
| "listr-update-renderer": "^0.5.0", | |||
| "listr-verbose-renderer": "^0.5.0", | |||
| "lodash": "^4.17.11" | |||
| "lodash": "^4.17.11", | |||
| "jasmine-marbles": "0.9.1" | |||
There was a problem hiding this comment.
The jasmine-marbles dependency is added twice 👀
There was a problem hiding this comment.
That's a resolution override because Nx is pinned on jasmine-marbles 0.8.3
This was referenced Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3059
What is the new behavior?
Supports RxJS 6/7 as a peer dependency
Does this PR introduce a breaking change?
Other information