Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rxjs 7 #3059

Closed
qortex opened this issue Jun 30, 2021 · 5 comments · Fixed by #3109
Closed

Support for rxjs 7 #3059

qortex opened this issue Jun 30, 2021 · 5 comments · Fixed by #3109

Comments

@qortex
Copy link
Contributor

qortex commented Jun 30, 2021

When trying to update to rxjs 7, I run into:

Package "@ngrx/store-devtools" has an incompatible peer dependency to "rxjs" (requires "^6.5.3", would install "7.1.0").

Is store-devtools compatible as-is with rxjs 7, or is there some work to ensure compatibility?

That would be great.

If accepted, I would be willing to submit a PR for this feature

[ x ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@qortex
Copy link
Contributor Author

qortex commented Jun 30, 2021

Sorry, it's actually much more deep: #3059

@qortex qortex closed this as completed Jun 30, 2021
@kylecordes
Copy link

@qortex Can you explain any further about the depth of RxJS 7 issues? In the comment above you link back to this same issue.

@qortex
Copy link
Contributor Author

qortex commented Aug 5, 2021

Woops sorry, bad copy/paste. Here is the link I was referring to: angular/angular#41897 (comment)

@Legiew
Copy link

Legiew commented Aug 5, 2021

The last angular version 12.2 supports both rxjs 6.x and 7.x so maybe we can open this issue again?

My question would also be what can we do to also make ngrx compatible to both versions?

We have a NX workspace with both angular and nest and we can't update to latest nest version (which is 8) because it requires rxjs 7.x.

@dobromyslov
Copy link

@Legiew totally agree. We use NX + Nest + Angular too and experiencing same issues. Angular 12.2 builds and runs fine but I can't say same thing about NgRx. It would be nice if RxJs gets RxJS 7+ support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants