Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function names to struct description #135

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Add function names to struct description #135

merged 1 commit into from
Nov 26, 2020

Conversation

LorcanMcVeigh
Copy link
Contributor

Proposed changes

These need to be added to fix errors in nginxinc/kubernetes-ingress#1233

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch on my own fork

@LorcanMcVeigh LorcanMcVeigh self-assigned this Nov 26, 2020
@LorcanMcVeigh LorcanMcVeigh merged commit 5231f69 into master Nov 26, 2020
@LorcanMcVeigh LorcanMcVeigh deleted the Update-struct branch November 26, 2020 14:36
@lucacome lucacome added the bug An issue reporting a potential bug label Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikestephen mikestephen mikestephen approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Assignees

@LorcanMcVeigh LorcanMcVeigh

Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LorcanMcVeigh @mikestephen @Dean-Coakley @lucacome