Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate tcp metrics with k8s object labels #1233

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Conversation

LorcanMcVeigh
Copy link
Contributor

Proposed changes

Add k8s object labels to tcp metrics.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

internal/configs/configurator.go Outdated Show resolved Hide resolved
internal/configs/configurator_test.go Outdated Show resolved Hide resolved
internal/k8s/controller.go Outdated Show resolved Hide resolved
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LorcanMcVeigh

Please see my comments and suggestions

internal/configs/configurator.go Outdated Show resolved Hide resolved
internal/configs/configurator_test.go Show resolved Hide resolved
internal/configs/transportserver.go Outdated Show resolved Hide resolved
internal/k8s/controller.go Outdated Show resolved Hide resolved
internal/k8s/controller.go Outdated Show resolved Hide resolved
internal/configs/configurator.go Outdated Show resolved Hide resolved
internal/configs/configurator.go Show resolved Hide resolved
internal/configs/configurator.go Outdated Show resolved Hide resolved
internal/k8s/controller.go Outdated Show resolved Hide resolved
go.sum Show resolved Hide resolved
@LorcanMcVeigh
Copy link
Contributor Author

force push was accidental, rebased against master

Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LorcanMcVeigh
Please see my comments and suggestions. I also discovered a bug, which I hand't noticed during the previous review :(

internal/configs/configurator.go Outdated Show resolved Hide resolved
internal/configs/configurator.go Outdated Show resolved Hide resolved
internal/configs/configurator.go Outdated Show resolved Hide resolved
internal/configs/configurator_test.go Outdated Show resolved Hide resolved
internal/configs/configurator.go Outdated Show resolved Hide resolved
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

internal/configs/configurator.go Outdated Show resolved Hide resolved
internal/configs/configurator_test.go Outdated Show resolved Hide resolved
@LorcanMcVeigh LorcanMcVeigh merged commit 45823d3 into master Dec 14, 2020
@LorcanMcVeigh LorcanMcVeigh deleted the annotate-tcp branch December 14, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants