-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description for enabling experimental features #2546
Add description for enabling experimental features #2546
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2546 +/- ##
=======================================
Coverage 89.29% 89.29%
=======================================
Files 100 100
Lines 7633 7633
Branches 50 50
=======================================
Hits 6816 6816
Misses 761 761
Partials 56 56 ☔ View full report in Codecov by Sentry. |
site/content/includes/installation/install-gateway-api-experimental-features.md
Outdated
Show resolved
Hide resolved
site/content/includes/installation/install-gateway-api-experimental-features.md
Outdated
Show resolved
Hide resolved
site/content/includes/installation/install-gateway-api-experimental-features.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Added a number of suggestions and confirmed input from other reviewers, but nothing critically requires editing.
site/content/includes/installation/install-gateway-api-experimental-features.md
Outdated
Show resolved
Hide resolved
site/content/includes/installation/install-gateway-api-experimental-features.md
Outdated
Show resolved
Hide resolved
site/content/includes/installation/install-gateway-api-experimental-features.md
Show resolved
Hide resolved
site/content/includes/installation/install-gateway-api-experimental-features.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approved, responded to the threads. Good to resolve them all, didn't want to do it myself in case the context was missed.
2279ee4
to
721c2bd
Compare
…nk lines to tables
721c2bd
to
b58bc2c
Compare
Proposed changes
Add includes description for enabling experimental features and the risks that are associated with using experimental features.
Problem: There is insufficient documentation on enabling experimental features in our guides.
Solution: Add an includes description for enabling experimental features that we can use for any guides on experimental features. Also updated gateway api compatibility document.
Testing: Locally generated the documentation through Hugo and it works.
Closes #2481
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.