-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NGINX Plus R33 support #2728
NGINX Plus R33 support #2728
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2728 +/- ##
==========================================
+ Coverage 89.40% 89.86% +0.46%
==========================================
Files 110 107 -3
Lines 10913 10997 +84
Branches 50 50
==========================================
+ Hits 9757 9883 +126
+ Misses 1098 1054 -44
- Partials 58 60 +2 ☔ View full report in Codecov by Sentry. |
site/content/includes/installation/nginx-plus/nginx-plus-secret.md
Outdated
Show resolved
Hide resolved
@ADubhlaoich this is a draft until r33 is out, but the docs are ready for review |
site/content/includes/installation/nginx-plus/docker-registry-secret.md
Outdated
Show resolved
Hide resolved
6219f17
to
8f676d9
Compare
At a quick review the documentation changes LGTM though I will give them a more thorough look again. I'm trying to grok how error messages are written (and handled), as they are huge concern for R33. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀
Adding support for NGINX Plus R33. The major change with this release is that NGINX Plus now requires a JWT in order to run. A user must create a Secret with this JWT and supply the secret name to NGF when installing. A user can also create client SSL and CA Secrets for NIM connections. All of these Secrets are mounted to the nginx container. Because of the new usage reporting method, the old usage reporting method has been removed and CLI arguments have been altered. Since this release is a breaking change for N+ users, the choice was made to remove the unused usage reporting flags instead of deprecating them. Updated documentation to describe this process, while also cleaning up the JWT docker registry process for N+.
f19394d
to
ef99c73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of small suggestions. overall, looks good
Adding support for NGINX Plus R33. The major change with this release is that NGINX Plus now requires a JWT in order to run. A user must create a Secret with this JWT and supply the secret name to NGF when installing. A user can also create client SSL and CA Secrets for NIM connections. All of these Secrets are mounted to the nginx container.
Because of the new usage reporting method, the old usage reporting method has been removed and CLI arguments have been altered. Since this release is a breaking change for N+ users, the choice was made to remove the unused usage reporting flags instead of deprecating them.
Updated documentation to describe this process, while also cleaning up the JWT docker registry process for N+.
Testing: Verified that usage reports are sent when everything is configured properly. Also verified that updates to the Secret are propagated.
Closes #2271
Closes #2709
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.