Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move conformance tests to tests directory #1969

Merged
merged 3 commits into from
May 20, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented May 14, 2024

Proposed changes

Problem: The conformance directory is outside of our tests directory containing all of our tests. This conformance directory has a separate Makefile with many duplicated commands and variables.
At release time we have to update all the versions in multiple places.

Solution: Move the conformance tests inside the tests directory and consolidate the Makefile so it's easier to maintain and update at release time

Closes #1977

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels May 14, 2024
@lucacome lucacome force-pushed the chore/conformance-tests branch 14 times, most recently from 6173fbd to 04470a5 Compare May 15, 2024 19:48
@lucacome lucacome marked this pull request as ready for review May 15, 2024 19:48
@lucacome lucacome requested a review from a team as a code owner May 15, 2024 19:48
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucacome lucacome requested a review from a team as a code owner May 16, 2024 16:14
@lucacome lucacome requested a review from ciarams87 May 16, 2024 16:17
@lucacome
Copy link
Member Author

Thanks for catching those @ciarams87 ! I have updated them.

@lucacome lucacome requested a review from a team May 16, 2024 16:19
@lucacome lucacome force-pushed the chore/conformance-tests branch 2 times, most recently from ffccea9 to e7b69b8 Compare May 16, 2024 18:01
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/conformance.yml Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
tests/Dockerfile Show resolved Hide resolved
docs/developer/testing.md Outdated Show resolved Hide resolved
tests/Makefile Outdated Show resolved Hide resolved
tests/Makefile Show resolved Hide resolved
tests/Makefile Show resolved Hide resolved
tests/README.md Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
@sjberman
Copy link
Contributor

https://github.com/kubernetes-sigs/gateway-api/tree/main/conformance/reports/v1.0.0/nginxinc-nginx-gateway-fabric will need its README updated (as well as when we introduce our next release that supports v1.1.0).

docs/developer/quickstart.md Outdated Show resolved Hide resolved
tests/Makefile Outdated Show resolved Hide resolved
@lucacome lucacome requested a review from a team May 20, 2024 22:00
@lucacome lucacome enabled auto-merge (squash) May 20, 2024 22:20
@lucacome lucacome merged commit 18671fb into nginxinc:main May 20, 2024
42 checks passed
@lucacome lucacome deleted the chore/conformance-tests branch May 20, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Consolidate test directories
3 participants