-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move conformance tests to tests directory #1969
Conversation
6173fbd
to
04470a5
Compare
c246b1b
to
d0974eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall!
There's just a couple of developer docs that need to be updated as well:
Thanks for catching those @ciarams87 ! I have updated them. |
ffccea9
to
e7b69b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
1ed2846
to
ffbdb1d
Compare
7150136
to
1be1f59
Compare
https://github.com/kubernetes-sigs/gateway-api/tree/main/conformance/reports/v1.0.0/nginxinc-nginx-gateway-fabric will need its README updated (as well as when we introduce our next release that supports v1.1.0). |
b5ef0a0
to
400ae2e
Compare
4cbfd76
to
ba88062
Compare
ba88062
to
ecf4546
Compare
Proposed changes
Problem: The conformance directory is outside of our tests directory containing all of our tests. This conformance directory has a separate Makefile with many duplicated commands and variables.
At release time we have to update all the versions in multiple places.
Solution: Move the conformance tests inside the tests directory and consolidate the Makefile so it's easier to maintain and update at release time
Closes #1977
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.