-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Helm tests on release tag #1255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjee19
force-pushed
the
bug/helm-tests-fail-release-tag
branch
from
November 16, 2023 22:40
475971f
to
c3e8159
Compare
bjee19
changed the title
TESTING WORKFLOW, NOT READY: Change from using tags to hardcoded path and version
Fix Helm tests on release tag
Nov 17, 2023
bjee19
force-pushed
the
bug/helm-tests-fail-release-tag
branch
from
November 17, 2023 19:44
7aa78ee
to
5c50d4a
Compare
sjberman
reviewed
Nov 20, 2023
lucacome
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
sjberman
approved these changes
Nov 20, 2023
bjee19
force-pushed
the
bug/helm-tests-fail-release-tag
branch
from
November 20, 2023 18:23
9c443f2
to
6d0e48f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Helm tests on release tag and replace
cut
commands.Problem: Helm tests fail on release tag because the
kind load
command did not work when the provided images spanned multiple lines. Also,cut
commands did not work as input was not a single value.Solution: Instead of using
steps.*.outputs.tags
which can output multiple lines, changed to use the hardcoded path to the image and a specific version.Testing: Manually verified on fork that the change works on a release tag.
Closes #1190
Checklist
Before creating a PR, run through this checklist and mark each as complete.