Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm tests fail on release tag #1190

Closed
kate-osborn opened this issue Oct 24, 2023 · 1 comment · Fixed by #1255
Closed

Helm tests fail on release tag #1190

kate-osborn opened this issue Oct 24, 2023 · 1 comment · Fixed by #1255
Assignees
Labels
refined Requirements are refined and the issue is ready to be implemented. release-engineering Relates to all release engineering tasks size/small Estimated to be completed within ~2 days
Milestone

Comments

@kate-osborn
Copy link
Contributor

kate-osborn commented Oct 24, 2023

Describe the bug
The helm tests fail on release tag pipelines trying to load multiple docker images onto the kind cluster:

kind load docker-image ghcr.io/nginxinc/nginx-gateway-fabric:1.0.0
ghcr.io/nginxinc/nginx-gateway-fabric:latest ghcr.io/nginxinc/nginx-gateway-fabric/nginx:1.0.0
ghcr.io/nginxinc/nginx-gateway-fabric/nginx:latest

error:

Image: "ghcr.io/nginxinc/nginx-gateway-fabric:1.0.0" with ID "sha256:c3bcd92b94503b16b896f9963234996b1edfa5814debb6eace0ff5f53ba17cb6" not yet present on node "kind-control-plane", loading...
/home/runner/work/_temp/2f2c899c-8a58-460f-9706-1fb7b8f55594.sh: line 5: ghcr.io/nginxinc/nginx-gateway-fabric:latest: No such file or directory

It is possible to load multiple images in one command but the images must be separated by a space, not a newline:

kind load docker-image ghcr.io/nginxinc/nginx-gateway-fabric:1.0.0 ghcr.io/nginxinc/nginx-gateway-fabric:latest ghcr.io/nginxinc/nginx-gateway-fabric/nginx:1.0.0 ghcr.io/nginxinc/nginx-gateway-fabric/nginx:latest

Expected behavior
Helm tests pass on release tag pipelines

Pipeline failure for v1.0.0: https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/6631103099/job/18014209953

@sjberman sjberman added the release-engineering Relates to all release engineering tasks label Oct 24, 2023
@sjberman sjberman added this to the v1.1.0 milestone Oct 24, 2023
@sjberman
Copy link
Contributor

sjberman commented Oct 25, 2023

Another issue that affects both this workflow and the conformance test workflow is when we access steps.ngf-meta.outputs.tags, it contains both elements, and the cut command fails because of this. Seems like the job passes anyway.

Doesn't seem like we need the latest image at all, maybe we can update the meta jobs in both workflows to not include latest.

@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days labels Nov 13, 2023
@bjee19 bjee19 self-assigned this Nov 13, 2023
@bjee19 bjee19 moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Nov 15, 2023
@bjee19 bjee19 moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric Nov 20, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refined Requirements are refined and the issue is ready to be implemented. release-engineering Relates to all release engineering tasks size/small Estimated to be completed within ~2 days
Projects
Archived in project
4 participants