Skip to content

Fix field path in error message for HTTPRoute path validation #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2023
Merged

Fix field path in error message for HTTPRoute path validation #587

merged 2 commits into from
Apr 21, 2023

Conversation

@pleshakov
Copy link
Contributor

Fix field path in error message for HTTPRoute path validation

Bug was introduced in 52fab05

Before:

 [spec.rules[0].matches[0].path: Unsupported value: "RegularExpression": supported values: "PathPrefix", spec.rules[0].matches[0].path: Invalid value: "/$coffee": cannot contain $]

After

 [spec.rules[0].matches[0].path.type: Unsupported value: "RegularExpression": supported values: "PathPrefix", spec.rules[0].matches[0].path.value: Invalid value: "/$coffee": cannot contain $]

@pleshakov pleshakov requested a review from a team as a code owner April 21, 2023 16:56
@github-actions github-actions bot added the bug Something isn't working label Apr 21, 2023
kate-osborn
kate-osborn reviewed Apr 21, 2023
View reviewed changes
@pleshakov pleshakov merged commit f36e8be into main Apr 21, 2023
@pleshakov pleshakov deleted the fix/field-path-in-error branch April 21, 2023 17:27
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
@miledxz
Fix field path in error message for HTTPRoute path validation (nginx#587
51f627e 
)

Bug was introduced in 52fab05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kate-osborn kate-osborn kate-osborn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pleshakov @kate-osborn