Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set stream status zone if hostname exists #2684

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

sjberman
Copy link
Collaborator

Problem: Noticed during conformance tests, the stream server blocks did not have a hostname, and therefore the status_zone value was empty and invalid.

Solution: Only set the status_zone directive if it has a value.

Closes #2683

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Stream status_zone directive is no longer set if its value is empty.

Problem: Noticed during conformance tests, the stream server blocks did not have a hostname, and therefore the status_zone value was empty and invalid.

Solution: Only set the status_zone directive if it has a value.
@github-actions github-actions bot added the bug Something isn't working label Oct 11, 2024
@sjberman sjberman marked this pull request as ready for review October 11, 2024 21:35
@sjberman sjberman requested a review from a team as a code owner October 11, 2024 21:35
@sjberman sjberman enabled auto-merge (squash) October 11, 2024 21:40
@sjberman sjberman merged commit 3748661 into nginx:main Oct 11, 2024
38 checks passed
@sjberman sjberman deleted the fix/stream-zone branch October 11, 2024 21:57
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Problem: Noticed during conformance tests, the stream server blocks did not have a hostname, and therefore the status_zone value was empty and invalid.

Solution: Only set the status_zone directive if it has a value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release-notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

status_zone metric invalid when stream hostname is empty
4 participants