Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

status_zone metric invalid when stream hostname is empty #2683

Closed
sjberman opened this issue Oct 11, 2024 · 0 comments · Fixed by #2684
Closed

status_zone metric invalid when stream hostname is empty #2683

sjberman opened this issue Oct 11, 2024 · 0 comments · Fixed by #2684
Labels
bug Something isn't working
Milestone
v1.5.0

Comments

@sjberman
Copy link
Collaborator

While running the conformance tests, stream servers were being configured through TLSRoutes in such a way where the hostname value was empty. This caused the status_zone directive to be set with an empty value, and nginx would fail to reload.

We should only set status_zone if there's a value for it.
@sjberman sjberman added the bug Something isn't working label Oct 11, 2024
@sjberman sjberman added this to the v1.5.0 milestone Oct 11, 2024
@sjberman sjberman mentioned this issue Oct 11, 2024
Merged
6 tasks
@lucacome lucacome moved this to ✅ Done in NGINX Gateway Fabric Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

Only set stream status zone if hostname exists sjberman/nginx-gateway-fabric
1 participant
@sjberman