add horizontalpodautoscaler #3249

coolbry95 · 2022-11-14T18:03:47Z

Proposed changes

Adds the horizontalpodautoscaler for the ingress controller

Checklist

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have checked that all unit tests pass after adding my changes
I have updated necessary documentation
I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

codecov-commenter · 2022-11-16T17:30:09Z

Codecov Report

Merging #3249 (62c2520) into main (2ee3f20) will not change coverage.
The diff coverage is n/a.

❗ Current head 62c2520 differs from pull request most recent head d40fb21. Consider uploading reports for the commit d40fb21 to get more accurate results

@@           Coverage Diff           @@
##             main    #3249   +/-   ##
=======================================
  Coverage   52.64%   52.64%           
=======================================
  Files          59       59           
  Lines       16107    16107           
=======================================
  Hits         8480     8480           
  Misses       7343     7343           
  Partials      284      284

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

lucacome · 2022-11-18T00:09:28Z

deployments/helm-chart/values.yaml

Suggested change

lucacome · 2022-11-18T00:10:11Z

deployments/helm-chart/README.md

Suggested change

`controller.autoscaling.targetCPUUtilizationPercentage`` | The target cpu utilization percentage. | 50

`controller.autoscaling.targetMemoryUtilizationPercentage`` | The target memory utilization percentage. | 50

`controller.autoscaling.targetCPUUtilizationPercentage` | The target CPU utilization percentage. | 50

`controller.autoscaling.targetMemoryUtilizationPercentage` | The target memory utilization percentage. | 50

lucacome · 2022-11-18T00:33:43Z

deployments/helm-chart/templates/controller-hpa.yaml

Suggested change

targetAverageUtilization: {{ .Values.controller.autoscaling.targetCPUUtilizationPercentage }}

This doesn't seem to be a field?

lucacome · 2022-11-18T00:45:14Z

deployments/helm-chart/templates/controller-hpa.yaml

Suggested change

targetAverageUtilization: {{ .Values.controller.autoscaling.targetMemoryUtilizationPercentage }}

same as the one above, not a field

lucacome · 2022-11-18T00:45:58Z

deployments/helm-chart/templates/controller-hpa.yaml

autoscaling/v2 is only available starting from k8s 1.23, so I think we need to check the version before deploying this

@lucacome Yes I believe you are correct. We need to verify this.

That is why I left both types of resources. Wasn't sure how much templating we wanted to do to support older versions.

what do you mean by both types?

@coolbry95 can you clarify by both types?

Types is the wrong word. I should have said apiVersion. I think this is the simplest way though. Just support autoscaling/v2.

For example we could template and add conditionals to support autoscaling/v1 and autoscaling/v2 at the same time.

lucacome · 2022-11-18T00:52:49Z

deployments/helm-chart/templates/controller-hpa.yaml

Suggested change

{{- if and .Values.controller.autoscaling.enabled (or (eq .Values.controller.kind "deployment")) -}}

{{- if and .Values.controller.autoscaling.enabled (eq .Values.controller.kind "deployment") -}}

Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.9.14 to 2022.9.24. - [Release notes](https://github.com/certifi/python-certifi/releases) - [Commits](certifi/python-certifi@2022.09.14...2022.09.24) --- updated-dependencies: - dependency-name: certifi dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Venktesh Shivam Patel <[email protected]>

Co-authored-by: Jakub Jarosz <[email protected]>

…ginx#3102)

* update path validation

* Fix staticcheck linter issues in k8s package * Fix linter issues in nginx package

…#3117) Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.17.7 to 1.17.8. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@config/v1.17.7...config/v1.17.8) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Upload SBOM to Azure

AWS doesn't accept the tag `latest` and causes the pipeline to throw an error.

Bumps [anchore/sbom-action](https://github.com/anchore/sbom-action) from 0.13.0 to 0.13.1. - [Release notes](https://github.com/anchore/sbom-action/releases) - [Commits](anchore/sbom-action@v0.13.0...v0.13.1) --- updated-dependencies: - dependency-name: anchore/sbom-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [isort/isort-action](https://github.com/isort/isort-action) from 1.0.0 to 1.1.0. - [Release notes](https://github.com/isort/isort-action/releases) - [Changelog](https://github.com/isort/isort-action/blob/master/CHANGELOG.md) - [Commits](isort/isort-action@v1.0.0...v1.1.0) --- updated-dependencies: - dependency-name: isort/isort-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…#3230) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.13.1 to 1.14.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.13.1...v1.14.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…lts (nginx#3236)

* Watch subset of namespaces for secrets Add new command line option "watch-secret-namespace" that can be used to configure namespaces watched for secrets. Closes nginx#3154 * Apply suggestions from code review Co-authored-by: Ciara Stacke <[email protected]> * Update cmd/nginx-ingress/flags.go Co-authored-by: Ciara Stacke <[email protected]>

Co-authored-by: “shaun-nx” <“[email protected]”>

To find the correct binary to use for the build when a user checks out a tag, we need to match the exact commit for the tag. `git tag --contains` would list all the tags containing the commit, but we need to verify that the commit we're on matches the current tag.

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.25.3 to 0.25.4. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.25.3...v0.25.4) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [k8s.io/code-generator](https://github.com/kubernetes/code-generator) from 0.25.3 to 0.25.4. - [Release notes](https://github.com/kubernetes/code-generator/releases) - [Commits](kubernetes/code-generator@v0.25.3...v0.25.4) --- updated-dependencies: - dependency-name: k8s.io/code-generator dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…13.21 to 1.13.22 (nginx#3242) Bump github.com/aws/aws-sdk-go-v2/service/marketplacemetering Bumps [github.com/aws/aws-sdk-go-v2/service/marketplacemetering](https://github.com/aws/aws-sdk-go-v2) from 1.13.21 to 1.13.22. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@service/swf/v1.13.21...service/xray/v1.13.22) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/marketplacemetering dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…x#3246) Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.17.10 to 1.18.0. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@config/v1.17.10...config/v1.18.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…inx#3238) * Create separate type for namespaced watchers * Create separate type for namespaced watchers in certmanager controller * Create separate type for namespaced watchers in extdns controller * Fix case where namespace is not watching secrets

Pin ubi8 image to unblock nap ubi builds

coolbry95 requested a review from a team as a code owner November 14, 2022 18:03

coolbry95 requested review from jjngx, lucacome and shaun-nx November 14, 2022 18:03

github-actions bot added the documentation Pull requests/issues for documentation label Nov 14, 2022

shaun-nx self-assigned this Nov 17, 2022

shaun-nx approved these changes Nov 17, 2022

View reviewed changes

jjngx approved these changes Nov 17, 2022

View reviewed changes

vepatel approved these changes Nov 17, 2022

View reviewed changes

lucacome suggested changes Nov 18, 2022

View reviewed changes

lucacome reviewed Nov 18, 2022

View reviewed changes

dependabot bot and others added 18 commits November 18, 2022 11:18

Fix staticcheck linter issues (nginx#3097)

296737d

Co-authored-by: Venktesh Shivam Patel <[email protected]>

Add RBAC for coordination.k8s.io/leases (nginx#3101)

5d9ccff

Co-authored-by: Jakub Jarosz <[email protected]>

Eliminate dead code (nginx#3104)

fcbbca9

Add ARCH in Makefile, make Dockerfile more compatible with podman (n…

6b0a2c9

…ginx#3102)

Fix helm chart issue when set controller.strategy (nginx#3106)

88fb869

Optimise path validation (nginx#3094)

3406737

* update path validation

Fix staticcheck linter issues in k8s, nginx packages (nginx#3107)

f07a0a8

* Fix staticcheck linter issues in k8s package * Fix linter issues in nginx package

Apdoslogconf will warning case format is not splunk (nginx#2991)

b14dc84

add canary header and update syslog yaml for AP tests (nginx#3116)

59ed736

Update packages for CVE-2022-40674 (nginx#3115)

3d696b7

Pass Git info to Docker (nginx#3112)

28c0449

Update helm rbac template for watch-ns (nginx#3122)

ab8ac9c

Announce release in Community Slack (nginx#3124)

de7bb29

Upload Release artifacts to Azure (nginx#3123)

becef0b

Upload SBOM to Azure

Don't use latest tag for AWS images (nginx#3125)

a77aa1b

AWS doesn't accept the tag `latest` and causes the pipeline to throw an error.

dependabot bot and others added 25 commits November 18, 2022 11:18

Unwrap error (nginx#3234)

26d6b5c

Remove unnecessary arg in generateTransportServerHealthCheckWithDefau…

9f40d88

…lts (nginx#3236)

Always print build info, add flags used (nginx#3231)

c7e31dc

Update script logic for validating tag (nginx#3237)

547e455

Co-authored-by: “shaun-nx” <“[email protected]”>

Remove ineffective break (nginx#3235)

795aea1

Add context to http calls (nginx#3233)

15577fa

Run golangci-lint in pre-commit only for changed files (nginx#3247)

cabfc2c

Add automated tests for -watch-secret-namespace (nginx#3245)

a0ea7e4

Add linter for GitHub Actions (nginx#3251)

99c4f57

Update packages for CVEs (nginx#3258)

8ea687c

Remove support for k8s < 1.21 (nginx#3252)

88572dd

feat: F5-hugo Theme bump - November (nginx#3263)

1421bed

Update minimum version in k8s version check (nginx#3265)

6c4e87b

fix: Pin ubi8 image to unblock nap ubi builds (nginx#3267)

096a3bb

Pin ubi8 image to unblock nap ubi builds

add horizontalpodautoscaler

d40fb21

coolbry95 force-pushed the addhpa branch from 62c2520 to d40fb21 Compare November 18, 2022 16:18

github-actions bot added dependencies Pull requests that update a dependency file tests Pull requests that update tests labels Nov 18, 2022

coolbry95 closed this Nov 18, 2022

shaun-nx mentioned this pull request Nov 21, 2022

add horizontalpodautoscaler #3276

Merged

6 tasks

-`controller.autoscaling.targetCPUUtilizationPercentage`` | The target cpu utilization percentage. | 50
-`controller.autoscaling.targetMemoryUtilizationPercentage`` | The target memory utilization percentage. | 50
+`controller.autoscaling.targetCPUUtilizationPercentage` | The target CPU utilization percentage. | 50
+`controller.autoscaling.targetMemoryUtilizationPercentage` | The target memory utilization percentage. | 50

	{{- if and .Values.controller.autoscaling.enabled (or (eq .Values.controller.kind "deployment")) -}}
	{{- if and .Values.controller.autoscaling.enabled (eq .Values.controller.kind "deployment") -}}

add horizontalpodautoscaler #3249

add horizontalpodautoscaler #3249

Uh oh!

Conversation

coolbry95 commented Nov 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Checklist

Uh oh!

codecov-commenter commented Nov 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

coolbry95 commented Nov 14, 2022 •

edited

Loading

codecov-commenter commented Nov 16, 2022 •

edited

Loading