Skip to content

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Sep 26, 2022

Proposed changes

Fix linting issues reported by staticcheck in the configs package

$ staticcheck internal/configs/*.go
internal/configs/configurator.go:258:20: error strings should not be capitalized (ST1005)
...
internal/configs/parsing_helpers.go:108:13: error strings should not be capitalized (ST1005)
...

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested review from a team, ciarams87, lucacome and shaun-nx September 26, 2022 16:20
@vepatel vepatel added the chore Pull requests for routine tasks label Sep 26, 2022
@github-actions github-actions bot removed the chore Pull requests for routine tasks label Sep 26, 2022
@jjngx jjngx requested a review from a team September 26, 2022 18:34
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #3097 (1efcd4f) into main (b574d09) will increase coverage by 0.01%.
The diff coverage is 23.40%.

@@            Coverage Diff             @@
##             main    #3097      +/-   ##
==========================================
+ Coverage   52.23%   52.24%   +0.01%     
==========================================
  Files          58       58              
  Lines       16045    16045              
==========================================
+ Hits         8381     8383       +2     
+ Misses       7386     7384       -2     
  Partials      278      278              
Impacted Files Coverage Δ
internal/configs/configurator.go 37.06% <15.00%> (ø)
internal/configs/parsing_helpers.go 67.64% <71.42%> (ø)
...ternal/k8s/appprotect/app_protect_configuration.go 86.74% <0.00%> (+0.57%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx merged commit 7a3533b into main Sep 27, 2022
@jjngx jjngx deleted the staticcheck branch September 27, 2022 07:41
@ciarams87 ciarams87 added the chore Pull requests for routine tasks label Sep 27, 2022
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants