-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add health checks documentation #673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhurley
requested review from
oliveromahony,
Dean-Coakley,
Jcahilltorre,
craigell,
olli-holmala,
spencerugbo and
aphralG
May 15, 2024 09:45
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
May 15, 2024
✅ Deploy Preview for agent-public-docs canceled.
|
Jcahilltorre
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with suggestions.
Have a look at the F5 NGINX documentation style guide (WIP) for the background to some of the suggestions.
@dhurley Is this doc for v2 or v3? |
Its for v2 |
Co-authored-by: Jon Torre <[email protected]>
aphralG
approved these changes
May 15, 2024
oliveromahony
approved these changes
May 15, 2024
nginx-seanmoloney
approved these changes
May 16, 2024
Co-authored-by: Jon Torre <[email protected]>
This commit changes the list of NGINX Agent variables to a table showing how it maps to the CLI flags, with an exception for the variable that doesn't have a flag yet. It links to the CLI flag section so that the reader can view the descriptions for additional context.
* Add pending health status for Agent v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Pull requests for routine tasks
dependencies
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add health checks documentation
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)