Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending health status #672

Merged
merged 3 commits into from
May 28, 2024
Merged

Add pending health status #672

merged 3 commits into from
May 28, 2024

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented May 9, 2024

Proposed changes

Example:

{
  "status": "PENDING",
  "checks": [
    {
      "name": "registration",
      "status": "OK"
    },
    {
      "name": "commandConnection",
      "status": "OK"
    },
    {
      "name": "metricsConnection",
      "status": "PENDING"
    }
  ]
}

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley self-assigned this May 9, 2024
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels May 9, 2024
Copy link

netlify bot commented May 9, 2024

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 16ac036
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/66447a11d1834a00080b957b

@oliveromahony oliveromahony added the highlights Highlights label to be placed in highlights section for a particular release label May 9, 2024
@oliveromahony oliveromahony merged commit ab64080 into main May 28, 2024
33 checks passed
@oliveromahony oliveromahony deleted the add-unknown-health-status branch May 28, 2024 09:46
dhurley added a commit that referenced this pull request May 28, 2024
* Add pending health status for Agent v2
oliveromahony pushed a commit that referenced this pull request May 28, 2024
* Add health checks documentation

* Clean up

* Apply suggestions from code review

Co-authored-by: Jon Torre <[email protected]>

* Add env vars

* Apply suggestions from code review

Co-authored-by: Jon Torre <[email protected]>

* Update health-checks.md

* Change environment variable list to table with CLI references

This commit changes the list of NGINX Agent variables to a table showing
how it maps to the CLI flags, with an exception for the variable that
doesn't have a flag yet. It links to the CLI flag section so that the
reader can view the descriptions for additional context.

* Fix small typo in Docker documentation

* Add pending health status (#672)

* Add pending health status for Agent v2

---------

Co-authored-by: Jon Torre <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies highlights Highlights label to be placed in highlights section for a particular release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants