Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions for log file and dynamic config directory #517

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Nov 17, 2023

Proposed changes

Change permissions for log file
Change permissions for dynamic config directory
Change permissions for socket in os.go

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit bb62bfe
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/6564aefa9d317c0008f2e437

@aphralG aphralG self-assigned this Nov 17, 2023
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Nov 17, 2023
@aphralG aphralG requested review from dhurley, oliveromahony, Dean-Coakley and craigell and removed request for dhurley November 17, 2023 10:28
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (789f6b1) 66.16% compared to head (e2742a5) 66.22%.

Files Patch % Lines
src/core/os.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
+ Coverage   66.16%   66.22%   +0.05%     
==========================================
  Files         118      118              
  Lines       13462    13462              
==========================================
+ Hits         8907     8915       +8     
+ Misses       3957     3947      -10     
- Partials      598      600       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aphralG aphralG changed the title Fix permissions for log file and dynamic config directory Fix permissions for log file, dynamic config directory Nov 24, 2023
@aphralG aphralG changed the title Fix permissions for log file, dynamic config directory Fix permissions for log file and dynamic config directory Nov 24, 2023
@aphralG aphralG merged commit 7bc5117 into main Nov 27, 2023
28 checks passed
@aphralG aphralG deleted the fix-permissions branch November 27, 2023 15:10
@aphralG aphralG mentioned this pull request Mar 15, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants