Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Advanced Metrics #598

Merged
merged 2 commits into from
Mar 25, 2024
Merged

fix Advanced Metrics #598

merged 2 commits into from
Mar 25, 2024

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Mar 14, 2024

Proposed changes

revert change to permissions from 600 back to 660

Change made in #517

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Mar 14, 2024
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Mar 14, 2024
Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit f99ca79
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/65f9bfa7be5e7b000805af3c

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.04%. Comparing base (808c064) to head (f99ca79).
Report is 6 commits behind head on main.

Files Patch % Lines
src/core/os.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   66.13%   66.04%   -0.09%     
==========================================
  Files         118      118              
  Lines       13485    13485              
==========================================
- Hits         8918     8906      -12     
- Misses       3963     3978      +15     
+ Partials      604      601       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aphralG aphralG merged commit 3e0b843 into main Mar 25, 2024
29 checks passed
@aphralG aphralG deleted the fix-advanced-metrics branch March 25, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants