fix: fix Linux default network interface parsing #331
Merged
+55
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes nginx#317 This fix resolves a problem where the header line of /proc/net/route is skipped twice when running on Linux. Additionally, this change also adds error checking to the Scanner performing the parsing operation.
✅ Deploy Preview for agent-public-docs canceled.
|
github-actions
bot
added
bug
|
Apparently, I'm blind and I did not see this PR: #318 |
oliveromahony
requested review from
oliveromahony,
dhurley,
Dean-Coakley,
craigell and
aphralG
aphralG
approved these changes
Jun 7, 2023
|
@dekobon Can you take a look at https://github.com/nginx/agent#installing-prerequisite-packages, then give This is likely an issue with all your current open PRs, can you please check them? |
I've figured out how to do this and I've updated the PRs accordingly. |
Dean-Coakley
approved these changes
Jun 8, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #317
This fix resolves a problem where the header line of /proc/net/route is skipped twice when running on Linux. This change also adds error checking to the Scanner performing the parsing operation.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)