NGINX agent cannot find the default network interface on Linux hosts.… #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nginx#317) The parser was skipping over the first (header) line with the first invocation of scanner.Scan(). The second invocation of scanner.Scan() called in the for loop points to the first line of route data; however, this line was being skipped. The tests were incorrect because they started with a newline before the header.
✅ Deploy Preview for agent-public-docs canceled.
|
|
@nkashiv @achawla2012 Could you review too and get this pushed through? |
The default interface is the one that has 0 for both destination and mask. Therefore we will also have to check if mask is 0 as well. https://github.com/jackpal/gateway/blob/master/gateway_parsers.go#L69 |
github-actions
bot
added
dependencies
documentation
|
LGTM |
6 tasks
|
Fixed in #331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#317)
The parser was skipping over the first (header) line with the first invocation of scanner.Scan(). The second invocation of scanner.Scan() called in the for loop points to the first line of route data; however, this line was being skipped. The tests were incorrect because they started with a newline before the header.
Proposed changes
Remove the logic to skip over the first line of route data for Linux hosts and corrected the unit tests.
Tested the change on Ubuntu 20.04.5 LTS
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)