-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add coverage to XML parsing in NAP Monitoring #288
add coverage to XML parsing in NAP Monitoring #288
Conversation
✅ Deploy Preview for agent-public-docs canceled.
|
I cross-referenced our list of scoped violations against the violations found in the
Let's please add all the XML examples from our table there as test cases so we can demonstrate that we parse them correctly. |
test/component/nginx-app-protect/monitoring/testData/events-out/xml_violation_url_data.json
Show resolved
Hide resolved
6b15dc5
to
cee75bd
Compare
cee75bd
to
61c54dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall everything is LGTM. Thanks for extending the XML support!
Proposed changes
This adds coverage to NAP Monitoring extension in Agent for parsing additional cases of the XML Violations to gather the Context information and stream it to NGINX Management Suite.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)