apply review;

nginx · Apr 17, 2023 · 6b15dc5 · 6b15dc5
1 parent f556ae7
commit 6b15dc5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/extensions/nginx-app-protect/monitoring/processor/nap.go b/src/extensions/nginx-app-protect/monitoring/processor/nap.go
@@ -449,13 +449,13 @@ func (f *NAPConfig) getViolations(logger *logrus.Entry) []*models.ViolationData
 				value = v.HeaderData.Value
 			} else if v.HeaderLength != "" {
 				isB64Decoded = true
-				decodedValue, err := base64.StdEncoding.DecodeString(v.HeaderName)
+				decodedName, err := base64.StdEncoding.DecodeString(v.HeaderName)
 				if err != nil {
 					logger.Errorf("could not decode the Header %s for %v", v.HeaderName, f.SupportID)
 					break
 				}
-				name = fmt.Sprintf("Header length: %s, exceeds Header length limit: %s", v.HeaderLength, v.HeaderLengthLimit)
-				value = string(decodedValue)
+				name = string(decodedName)
+				value = fmt.Sprintf("Header length: %s, exceeds Header length limit: %s", v.HeaderLength, v.HeaderLengthLimit)
 			}
 
 			if isB64Decoded {

diff --git a/src/extensions/nginx-app-protect/monitoring/processor/processor_test.go b/src/extensions/nginx-app-protect/monitoring/processor/processor_test.go
@@ -870,8 +870,8 @@ func TestNAPProcess(t *testing.T) {
 						Name:    "VIOL_HEADER_LENGTH",
 						Context: "header",
 						ContextData: &pb.ContextData{
-							Name:  "Header length: 42, exceeds Header length limit: 10",
-							Value: "Host: dflkdjfldkfldkfldkflkdflkdflkdlfkdlf",
+							Name:  "Host: dflkdjfldkfldkfldkflkdflkdflkdlfkdlf",
+							Value: "Header length: 42, exceeds Header length limit: 10",
 						},
 					},
 				},

diff --git a/...component/nginx-app-protect/monitoring/testData/events-out/xml_violation_header_data.json b/...component/nginx-app-protect/monitoring/testData/events-out/xml_violation_header_data.json
@@ -39,8 +39,8 @@
                 "Name": "VIOL_HEADER_LENGTH",
                 "Context": "header",
                 "ContextData": {
-                    "Name": "Header length: 42, exceeds Header length limit: 10",
-                    "Value": "Host: dflkdjfldkfldkfldkflkdflkdflkdlfkdlf"
+                    "Name": "Host: dflkdjfldkfldkfldkflkdflkdflkdlfkdlf",
+                    "Value": "Header length: 42, exceeds Header length limit: 10"
                 }
             }
         ]