Skip to content

Libervia-backend: Extract from old Libervia, add to new project structure#559

Merged
fricklerhandwerk merged 3 commits into
ngi-nix:mainfrom
OPNA2608:migrate-project/Libervia-backend
Mar 21, 2025
Merged

Libervia-backend: Extract from old Libervia, add to new project structure#559
fricklerhandwerk merged 3 commits into
ngi-nix:mainfrom
OPNA2608:migrate-project/Libervia-backend

Conversation

@OPNA2608
Copy link
Copy Markdown
Contributor

@OPNA2608 OPNA2608 commented Mar 7, 2025

Closes #553

@fricklerhandwerk
Copy link
Copy Markdown
Contributor

Would it make sense to tuck under Libervia, or are the other components distinct applications as opposed to just components of the same application?

@OPNA2608
Copy link
Copy Markdown
Contributor Author

OPNA2608 commented Mar 8, 2025

#553 named "Libervia-backend" specifically, so I extracted only that part of the project here. If that was meant to include the desktop client in that, then I have no issue with migrating that into here as well, putting it all under "Libervia", and dropping /projects-old/Libervia.

@fricklerhandwerk
Copy link
Copy Markdown
Contributor

Yes, please put everything together! :)

@OPNA2608 OPNA2608 force-pushed the migrate-project/Libervia-backend branch from 79c2701 to 9d52a8c Compare March 11, 2025 17:30
@OPNA2608
Copy link
Copy Markdown
Contributor Author

Desktop client is now included in the new project structure:

  • handled in module
  • example for enabling the desktop client
  • test for the desktop client (which has to import & extend the backend test, as it requires the libervia backend + all the same setup & environment to work in the VM)

I think this should be ready for review now.

@OPNA2608 OPNA2608 marked this pull request as ready for review March 11, 2025 17:36
@OPNA2608 OPNA2608 requested a review from imincik March 11, 2025 17:37
@imincik imincik moved this to In review in Nix@NGI Mar 12, 2025
Copy link
Copy Markdown
Contributor

@imincik imincik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Code looks good to me.

My only concern is that we lack some conventions or templates for file naming and code structure. Currently, all project metadata looks slightly different.

@fricklerhandwerk
Copy link
Copy Markdown
Contributor

We'll get to stronger patterns once there's enough material to generalize over.

@fricklerhandwerk fricklerhandwerk merged commit 1408465 into ngi-nix:main Mar 21, 2025
@github-project-automation github-project-automation Bot moved this from In review to Done in Nix@NGI Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Implement project metadata for Libervia

3 participants