Refactor module composition#1134
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Merged
eljamm
force-pushed
the
modules
branch
2 times, most recently
from
c28401b to
b122fe9
Compare
and remove `sops-nix` from global import as it's already imported and works inside the individual tests that need it.
Which makes it possible to use demo-shell inside the NixOS tests and systems. In the future, we should look into separating this properly from production code.
fricklerhandwerk
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
nixos-modulesto the flake'snixosModulesdemo-shellin ngipkgs moduledemo-shellinside the NixOS tests, which we're gonna need for experimenting with Spike: Test all project demos #1028Needed for: #1118 #1123
Worked on this with @themadbit