xrsh: add shell demo#1118
Merged
Merged
Conversation
Contributor
|
Ahh good, these developments show that we need to refine our data model a bit. For instance we could have an extra field just for exactly one demo; that would nudge us to deliberately choose the intended experience for each application. |
| environment.variables = { | ||
| XRSH_PORT = toString cfg.port; | ||
| }; | ||
| demo-shell.xrsh = { |
Contributor
There was a problem hiding this comment.
Also it would be cleaner if we had a separate demo field that would imports the relevant modules, then demo implementation details wouldn't leak into production code.
themadbit
force-pushed
the
xrsh
branch
2 times, most recently
from
83435c5 to
df61fea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1111
nit-change: replaces hard-coded port with a modular variable XRSH_PORT
concerns:
currently depends on
@fricklerhandwerk, you had proposed that demo examples should ideally be the same as those used in the program/service module example. I have tried to implement that herein. However,
overviewdisplays both as different examples or rather, independently. I think it's redundant for a smoother user experience. How do you propose we approach this?