Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Fixes: Updated documentation and reporting, isoquant downgrading, adding 5 prime support #23

Merged
merged 18 commits into from
Jul 1, 2024

Conversation

atrull314
Copy link
Collaborator

Main Changes:

  • Add new qc table in multiqc report to show read counts at various points
  • Adding blaze scripts to pipeline
  • Upgrading blaze for 5 prime support
  • Downrading isoquant version

@atrull314 atrull314 requested a review from lianov July 1, 2024 14:37
Copy link

github-actions bot commented Jul 1, 2024

nf-core lint overall result: Failed ❌

Posted for pipeline commit 93c5c05

+| ✅ 170 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗   6 tests had warnings |!
-| ❌   2 tests failed       |-

❌ Test failures:

  • files_unchanged - .github/PULL_REQUEST_TEMPLATE.md does not match the template
  • files_unchanged - .github/workflows/linting_comment.yml does not match the template

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • nfcore_yml - nf-core version not set in .nf-core.yml

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-07-01 15:37:08

@lianov
Copy link
Member

lianov commented Jul 1, 2024

Adding for the record that this PR will close issue #10 and issue #22 (for 22, we have chosen to downgrade the version at this time until a more permanent fix is pushed to isoquant).

@lianov lianov merged commit fa1a0dd into nf-core:dev Jul 1, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants