Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isoquant memory issue #22

Closed
lianov opened this issue Jun 4, 2024 · 2 comments
Closed

Isoquant memory issue #22

lianov opened this issue Jun 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@lianov
Copy link
Member

lianov commented Jun 4, 2024

Description of the bug

Related to IsoQuant issue ablab/IsoQuant#189

This issue carries over to the pipeline in the latest version of IsoQuant. Prior to first release, we'll need to proceed with one of the two options below:

  • Check back on issue noted above to see if fixes have been applied (update and test in scnanoseq)
  • If no fixes have been applied, then downgrade IsoQuant to version 3.3.1
@lianov
Copy link
Member Author

lianov commented Jul 1, 2024

For the record, the fix in the meantime was to downgrade IsoQuant to 3.3.1. We will update or patch the pipeline once a fix becomes available from IsoQuant

@lianov lianov closed this as completed Jul 1, 2024
@lianov
Copy link
Member Author

lianov commented Aug 23, 2024

Adding one note here for the record: between the time this issue was closed and final changes for release, IsoQuant 3.5.0 was released. Since then this version has been upgraded in the pipeline with the fix we needed for the memory issue reported here.

As an additional bonus, this version drastically improved quantification as well (which were improvements that were on-going in the versions between 3.3.1 and 3.5.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant