Skip to content

Conversation

@atrigila
Copy link
Contributor

@atrigila atrigila commented Apr 30, 2025

Closes #1465

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.2.0.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@atrigila atrigila linked an issue Apr 30, 2025 that may be closed by this pull request
@atrigila
Copy link
Contributor Author

atrigila commented Apr 30, 2025

The template has to be merged first.
I also need to update the tests here.

@atrigila atrigila marked this pull request as ready for review May 5, 2025 12:27
@atrigila atrigila requested a review from pinin4fjords May 5, 2025 12:27
@atrigila
Copy link
Contributor Author

atrigila commented May 7, 2025

Tests are not being triggered automatically so I'll test the solution of closing and opening the ticket.

@atrigila atrigila closed this May 7, 2025
@atrigila atrigila reopened this May 7, 2025
@atrigila
Copy link
Contributor Author

atrigila commented May 7, 2025

24.04.2 tests are OK but latest-everything tests are failing because we require the template to be merged first.

@pinin4fjords
Copy link
Member

Sorry, been a busy couple of days, will try to resolve the template tomorrow.

@atrigila
Copy link
Contributor Author

atrigila commented May 8, 2025

No worries, no rush at all. I could also give a hand with the template if I have some time these days as well :)

Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is good now then?

Only thing I might suggest is some R code example somewhere in the docs illustrating how to access the different assay slots of that object.

@atrigila atrigila merged commit c3fe0e5 into nf-core:dev May 22, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify SummarizedExperiment output

4 participants