Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove local module RRNA_TRANSCRIPTS #541

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Remove local module RRNA_TRANSCRIPTS #541

merged 2 commits into from
Nov 28, 2024

Conversation

atrigila
Copy link

@atrigila atrigila commented Nov 27, 2024 •
edited
Loading

Related to: #526
Closes #542
Already replaced by nf-core module

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnafusion branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit afea934

+| ✅ 219 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-27 18:19:02

@nschcolnicov
Copy link

@atrigila Thanks for taking care of this, not sure what to do about the failing tests due to missing permissions

@nschcolnicov nschcolnicov mentioned this pull request Nov 27, 2024
Closed
@atrigila atrigila force-pushed the remove_local_rrnatranscripts branch from 02d8e90 to afea934 Compare November 27, 2024 18:17
@atrigila atrigila requested review from apeltzer and grst November 27, 2024 18:18
@atrigila atrigila merged commit 1aca475 into nf-core:dev Nov 28, 2024
7 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

@nschcolnicov nschcolnicov Awaiting requested review from nschcolnicov

@grst grst Awaiting requested review from grst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atrigila @nschcolnicov @apeltzer