Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update intro and usage documentation #396

Merged
merged 18 commits into from
Sep 13, 2023
Merged

update intro and usage documentation #396

merged 18 commits into from
Sep 13, 2023

Conversation

rannick
Copy link
Collaborator

@rannick rannick commented Sep 11, 2023

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnafusion branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Sep 11, 2023

nf-core lint overall result: Passed ✅

Posted for pipeline commit 3395388

+| ✅ 158 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-13 13:00:07

Copy link
Member

@peterpru peterpru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, it was very difficult to find problems 💯

| [StringTie](https://github.com/gpertea/stringtie) | `2.2.1` |

> Single-end reads are to be use as last-resort. Paired-end reads are recommended. FusionCatcher cannot be used with single-end reads shorter than 130 bp.
**nf-core/rnafusion** is a bioinformatics best-practice analysis pipeline for RNA sequencing consisting of several tools designed for detecting and visualizing fusion genes.

Copy link
Member

@peterpru peterpru Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be nice for potential users to have an overview of what the expected output is in 1-2 sentences? E.g. the output is a report in XX format with fusions from up to five different fusion callers.

Copy link
Member

@peterpru peterpru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

rannick and others added 11 commits September 13, 2023 14:22
Co-authored-by: Peter Pruisscher <[email protected]>
Co-authored-by: Peter Pruisscher <[email protected]>
Co-authored-by: Peter Pruisscher <[email protected]>
Co-authored-by: Peter Pruisscher <[email protected]>
Co-authored-by: Peter Pruisscher <[email protected]>
Co-authored-by: Peter Pruisscher <[email protected]>
Co-authored-by: Peter Pruisscher <[email protected]>
Co-authored-by: Peter Pruisscher <[email protected]>
@rannick rannick merged commit 2bfdb59 into dev Sep 13, 2023
@rannick rannick deleted the update_documentation branch September 13, 2023 13:15
@rannick rannick mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants