Skip to content

Conversation

gburnett-nvidia
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@gburnett-nvidia gburnett-nvidia requested review from a team as code owners October 13, 2025 18:01
@gburnett-nvidia gburnett-nvidia changed the title Parabricks bulk update: Upgrading workflows to Parabricks version 4.6 Parabricks bulk update: Upgrading modules to Parabricks version 4.6 Oct 13, 2025
nf-test-gpu:
runs-on: "runs-on=${{ github.run_id }}/family=g4dn.xlarge/image=ubuntu24-gpu-x64"
runs-on: "runs-on=${{ github.run_id }}/family=g4dn.8xlarge/image=ubuntu24-gpu-x64"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for this where we might need @mashehu for approval I think it looks good!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite a lot larger. Any way to make the test data smaller or what is causing this bloat?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current solution is to change it back to g4dn.xlarge before pushing to main (see the note in the README.md). Only starfusion and rnafq2bam have this higher requirement and it comes down to system memory. Even with the smallest test data possible, the memory on the g4dn.xlarge is not large enough.

The minimum system requirements for Parabricks are 100 GB of memory for 1 GPU so this instance matches that, although for most of the tests it looks like we can get away with less.

Is this satisfactory for now?

Copy link
Contributor

@mashehu mashehu Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current solution is to change it back to g4dn.xlarge before pushing to main

you mean you will switch this value back in this PR before merging or what do you mean with "pushing to main"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes for now I will change it back before merging so I can unblock this PR until we can think of a more permanent solution. I will do some testing on smaller instances to see if I can size it down to a 4xlarge or 2xlarge, but I know the 1xlarge won't work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finished my testing and everything was able to run on a g4dn.2xlarge, meaning that Parabricks is using 15-30 GB of system memory for the rnafq2bam module. I'd like to continue the discussion (maybe as a GitHub issue?) about if there's a better solution to testing this than having to manually change this in the nf-test-gpu.yml.

@famosab is there anything else you need to approve this PR or the starfusion one since they are both blocked by this issue?

@gburnett-nvidia gburnett-nvidia mentioned this pull request Oct 14, 2025
17 tasks
@gburnett-nvidia gburnett-nvidia added this pull request to the merge queue Oct 15, 2025
Merged via the queue into nf-core:master with commit bc4ad38 Oct 15, 2025
34 checks passed
@gburnett-nvidia gburnett-nvidia deleted the parabricks_46_update branch October 15, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants