Skip to content

Conversation

nvnieuwk
Copy link
Contributor

This PR serves as an example of the work being done in nf-core/tools#3779

@maxulysse
Copy link
Member

So this one replaces #8978 ?

@nvnieuwk
Copy link
Contributor Author

Not yet, I still need to update the subworkflows here

output:
tuple val(meta), path("bwamem2"), emit: index
path "versions.yml" , emit: versions
tuple val("${task.process}"), val('bwa-mem2'), eval("bwa-mem2 version 2>&1 | tail -1"), topic: versions, emit: versions1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be picky here, but the harshil alignment is not correct 😂

Comment on lines +54 to +62
- - process:
type: string
description: The process the versions were collected from
- tool:
type: string
description: The tool name
- version:
type: string
description: The version of the tool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good!
but if we want to automate it somehow, the values of the topic channel should be the same that we add for versions1: ${task.process}, bwa-mem2 and bwa-mem2 version 2>&1 | tail -1.
It doesn't look as nice, but it's the only way we can automate the generation of the meta.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks the main issue here is that the versions topic can consist of multiple tools here. I'm also not sure this needs automation as this will be in the template anyways. I've tried adding the automation, but it's not that trivial to do :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants