-
Notifications
You must be signed in to change notification settings - Fork 909
POC: topics #9159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
POC: topics #9159
Conversation
So this one replaces #8978 ? |
Not yet, I still need to update the subworkflows here |
output: | ||
tuple val(meta), path("bwamem2"), emit: index | ||
path "versions.yml" , emit: versions | ||
tuple val("${task.process}"), val('bwa-mem2'), eval("bwa-mem2 version 2>&1 | tail -1"), topic: versions, emit: versions1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be picky here, but the harshil alignment is not correct 😂
- - process: | ||
type: string | ||
description: The process the versions were collected from | ||
- tool: | ||
type: string | ||
description: The tool name | ||
- version: | ||
type: string | ||
description: The version of the tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good!
but if we want to automate it somehow, the values of the topic channel should be the same that we add for versions1
: ${task.process}
, bwa-mem2
and bwa-mem2 version 2>&1 | tail -1
.
It doesn't look as nice, but it's the only way we can automate the generation of the meta.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks the main issue here is that the versions topic can consist of multiple tools here. I'm also not sure this needs automation as this will be in the template anyways. I've tried adding the automation, but it's not that trivial to do :/
This PR serves as an example of the work being done in nf-core/tools#3779