fix: move circular-progress tv to progress #3321
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 7102042 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedThe pull request is closed. WalkthroughThe update involves a patch version change for the package "@nextui-org/theme". It includes a modification where the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- .changeset/strange-spoons-behave.md (1 hunks)
- packages/core/theme/src/components/index.ts (1 hunks)
- packages/core/theme/src/components/progress.ts (1 hunks)
Additional comments not posted (5)
.changeset/strange-spoons-behave.md (1)
2-5: Verify versioning and description in changeset.The changeset correctly identifies the package and the patch level. Ensure that the description "Remove circular-progress tv to progress" accurately reflects the changes made in the PR, as it seems a bit unclear.
packages/core/theme/src/components/index.ts (1)
Line range hint
1-38: Review exports for consistency with PR objectives.The file lists multiple component exports. It's crucial to verify that the export of
circular-progresshas been removed and replaced byprogressas described in the PR. However, this file does not show the removal explicitly, which could be due to the way the changes are presented here.packages/core/theme/src/components/progress.ts (3)
239-243: Check type declarations for consistency.The type declarations for
ProgressVariantPropsandProgressSlotsare consistent with the implementation of theprogresscomponent. Similarly, ensure that the types forCircularProgressVariantPropsandCircularProgressSlotsaccurately reflect the properties and slots of thecircularProgresscomponent.
245-245: Confirm export ofprogressandcircularProgresscomponents.The explicit export of both
progressandcircularProgresscomponents is crucial for their availability in other parts of the application. This change aligns with the PR's objectives and should be noted in the documentation if not already done.
139-238: Review newcircularProgresscomponent implementation.The implementation of the
circularProgresscomponent is well-documented and includes a variety of configurations for slots and variants. Ensure that the example usage in the comments is accurate and that the component behaves as expected in different configurations.Verification successful
Review new
circularProgresscomponent implementation.The
circularProgresscomponent is well-integrated and used in various parts of the codebase, including demos, documentation, and storybook files. The component appears to support a wide range of configurations and is documented for different use cases and variants. The example usage in the comments is accurate and aligns with the actual implementation.
- Verified Files:
apps/docs/components/demos/speed-progress.tsxapps/docs/content/docs/components/circular-progress.mdxpackages/components/progress/stories/circular-progress.stories.tsxpackages/components/progress/src/use-circular-progress.tsBased on the content of these files, the
circularProgresscomponent behaves as expected across different configurations.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the behavior of `circularProgress` in different configurations. # Test: Check the component in a development environment. echo "Manual testing required in development environment."Length of output: 112
Script:
#!/bin/bash # Search for instances of circularProgress in the codebase to verify its usage and configurations. # Find all occurrences of circularProgress in the repository rg 'circularProgress' --glob '!node_modules/*'Length of output: 2363
Script:
#!/bin/bash # Display the content of files where `circularProgress` is used to verify its configurations and usage. # List of files to inspect files=( "apps/docs/components/demos/speed-progress.tsx" "apps/docs/content/docs/components/circular-progress.mdx" "packages/components/progress/stories/circular-progress.stories.tsx" "packages/components/progress/src/use-circular-progress.ts" ) # Loop through each file and display its content for file in "${files[@]}"; do echo "File: $file" echo "-------------------------------------" cat "$file" echo -e "\n\n" doneLength of output: 19386
There was a problem hiding this comment.
Should it be a breaking change? Let's say I use individual package and my tailwindcss setup is like
"./node_modules/@nextui-org/theme/dist/components/circular-progress.js",With the change introduced in this PR, I need to change it to
"./node_modules/@nextui-org/theme/dist/components/progress.js",
ya, maybe could upgrade in next minor version, and let user know that |
|
Let's put it in v2.5.0. |
winchesHe
force-pushed
the
fix-circular-progress-style
branch
from
ca7d3d7
to
c3f86f5
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .changeset/angry-maps-serve.md (1 hunks)
Files skipped from review due to trivial changes (1)
- .changeset/angry-maps-serve.md
wingkwong
changed the title
Closes #
nextui-org/nextui-cli#85
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
Bug Fixes
New Features