Use Node.js version 18 #595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the current version (14) is still in active LTS status, the latest LTS version comes with performance improvements [1]. The performance improvements from version 16 should also apply [2]. Also update the npm version to a minimum of 8.6.0 since it corresponds with Node.js 18.0.0 per https://nodejs.org/en/download/releases/. [1]: https://nodejs.org/en/blog/release/v18.0.0/ [2]: https://nodejs.org/en/blog/release/v16.0.0/
nextstrain-bot
temporarily deployed
to
nextstrain-s-victorlin--a96e4k
6 tasks
victorlin
commented
Sep 27, 2022
| @@ -8,8 +8,8 @@ | |||
| "repository": "github:nextstrain/nextstrain.org", | |||
| "homepage": "https://nextstrain.org", | |||
| "engines": { | |||
| "node": "^14", | |||
| "npm": "^6.14" | |||
| "node": "^18", | |||
There was a problem hiding this comment.
This error from npm run build:
error UNHANDLED REJECTION error:0308010C:digital envelope routines::unsupported
was also observed in nextstrain/auspice#1520. Webpack, an Auspice dependency, is the culprit. This will be fixed once that PR is merged, released, and the Auspice version is bumped for this project.
|
This was premature and incomplete. Closing in favor of #635. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Although the current version (14) is still in active LTS status, the latest LTS version comes with performance improvements [1]. The performance improvements from version 16 should also apply [2].
Also update the npm version to a minimum of 8.6.0 since it corresponds with Node.js 18.0.0 per https://nodejs.org/en/download/releases/.
Related issue(s)
N/A
Tasks
npm installand build outputs for any dependency compatibility issuesTesting