-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Node.js version 12, add 18 #1560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
auspice-victorlin-updat-jfpodf
October 4, 2022 17:56
Inactive
This was referenced Oct 4, 2022
victorlin
force-pushed
the
victorlin/update-node-versions
branch
from
March 2, 2023 20:45
99762f4
to
1ca9076
Compare
Node.js v18 was released on 2022-04-19¹. ¹ https://github.com/nodejs/Release/blob/54e615d89bf2e056644e138e7e33714bfd1b67ee/README.md#release-schedule
Node.js v12 went from LTS to end-of-life status on 2022-04-30¹. ¹ https://github.com/nodejs/Release/blob/54e615d89bf2e056644e138e7e33714bfd1b67ee/README.md#end-of-life-releases
victorlin
force-pushed
the
victorlin/update-node-versions
branch
from
March 2, 2023 21:04
1ca9076
to
402828c
Compare
NPM version 9, release 2022-10-19, comes with several changes¹. None of the breaking changes seem to be relevant for usage with Auspice. ¹ https://github.com/npm/cli/releases/tag/v9.0.0
tsibley
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me by inspection.
jameshadfield
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me by inspection.
Same for me!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See commit messages.
Related issue(s)
Tasks
--openssl-legacy-provider
option.Testing