Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs when changing datasets with URL queries defined #613

Merged
merged 4 commits into from
Aug 5, 2018
Merged

Fix bugs when changing datasets with URL queries defined #613

merged 4 commits into from
Aug 5, 2018

Commits on Aug 4, 2018

  1. fix URL bug where region didn't exist in new dataset

    @jameshadfield
    jameshadfield committed Aug 4, 2018
    Configuration menu
    Copy the full SHA
    fd1fea4 View commit details
    Browse the repository at this point in the history

  2. fix URL bug when changing datasets with a genotype selected 

    Now falls back to the default colorBy
URL colorBy query is cleared
    @jameshadfield
    jameshadfield committed Aug 4, 2018
    Configuration menu
    Copy the full SHA
    aee2daa View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2018

  1. fall back to default colorBy / geo resolutions when valid 

    fallbacks for invalid colorBys / geo resolutions are now
1. JSON defined default
2. hardcoded default
3. any available value
    @jameshadfield
    jameshadfield committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    2cc26d5 View commit details
    Browse the repository at this point in the history

  2. ensure filters are valid upon dataset load

    @jameshadfield
    jameshadfield committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    79a3799 View commit details
    Browse the repository at this point in the history