-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs when changing datasets with URL queries defined #613
Conversation
Now falls back to the default colorBy URL colorBy query is cleared
@jameshadfield --- Nice work here. I did catch a small issue:
|
This is now fixed in be70819 |
P.S. this PR resolves #510 |
Thanks for fixing the flu issue. One more bug here @jameshadfield. If I start at http://localhost:4000/flu/seasonal/h3n2/ha/3y?c=lbi and go to "zika" I get an empty URL as expected, however Zika then has date coloring rather than its proper default of country. |
Oh... and another related bug (didn't think about filters until now). If I start at http://localhost:4000/ebola?f_authors=Kugelman_et_al and then go to "zika" I get a full app crash with |
fallbacks for invalid colorBys / geo resolutions are now 1. JSON defined default 2. hardcoded default 3. any available value
Fixed in 2cc26d5. I'd forgotten that we use auspice-hardcoded country & geo defaults. If a default is not specified in the JSONs, we now use these instead. |
Should be fixed in 79a3799 but needs testing |
@jameshadfield --- This is great. I can't find any more bugs. I think this new behavior of preserving state where possible definitely makes the app feel more unified. Please feel free to merge. |
Closes #611
Fixed for the colorBy & geoResolution cases.
This maintains the expected behavior when going from http://localhost:4000/local/flu/seasonal/h3n2/ha/6y?c=ep to the 3y dataset.