Fix the shift/option + mouseWheel zoom bug in entropy panel #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Fix the issue that shift/option + mouseWheel on the entropy panel doesn't update the query strings
gmaxandgmin.The root cause of the issue is that the
brushFinishedmethod doesn't dispatchchangeZoom(this.zoomCoordinates)for the ZoomEvent(ZoomEvent is the event emitted by shift/option + mouseWheel). Added the logic to dispatchchangeZoom(this.zoomCoordinates)for ZoomEvent.Related issue(s)
Fixes #1179
Related to #
Testing
Manually tested the following 3 cases.
gmaxandgminget in the URL.gmaxandgminget in the URL.