Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shift,option+mouseWheel zoom bugs in entropy panel #1179

Closed
eharkins opened this issue Jun 26, 2020 · 1 comment · Fixed by #1188
Closed

shift,option+mouseWheel zoom bugs in entropy panel #1179

eharkins opened this issue Jun 26, 2020 · 1 comment · Fixed by #1188
Labels
bug Something isn't working good first issue A relatively isolated issue appropriate for first-time contributors please take this issue

Comments

@eharkins
Copy link
Contributor

Current Behavior
Breaking this out from #1145

Zooming the entropy panel by the ctrl+mouseWheel does not update the URL query. Not sure what (if any) dispatches are occurring on this action

relevant code here

It looks like the keys that allow you to zoom on the entropy panel by scrolling are actually shift and option.

shift + scrolling doesn't update the zoom visually or in the query for me.
option + scrolling updates the zoom visually but not in the query as described in #1145

Expected behavior
If it is working, the bar should change in size (and the query should update with gmin and/or gmax).

How to reproduce
Steps to reproduce the current behavior:

  1. Go to https://nextstrain.org/flu/seasonal/h3n2/ha/2y

  2. On the entropy panel, hold either option or shift key and scroll while the mouse is over the grey bar:
    Screen Shot 2020-06-26 at 4 14 48 PM

  3. see expected behavior. the bug looks like either nothing happening or query not updating

Your environment: if browsing Nextstrain online

  • FWIW I am using external mouse not laptop touch pad.
@eharkins eharkins added bug Something isn't working please take this issue good first issue A relatively isolated issue appropriate for first-time contributors low priority labels Jun 26, 2020
@hangzho
Copy link
Contributor

hangzho commented Jul 17, 2020

Hi @eharkins, I'm new to this project. I've created a potential solution in my PR to fix this issue. Let me know if you have any questions or suggestions. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue A relatively isolated issue appropriate for first-time contributors please take this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants