Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #981 Add Japanese translation #1045

Merged
merged 6 commits into from
Apr 8, 2020

Conversation

yuryu
Copy link
Contributor

@yuryu yuryu commented Apr 7, 2020

Description of proposed changes

Adding the Japanese locale files.

Related issue(s)

Fixes #981

Testing

Change the locale setting to Japanese and check translations.

@jameshadfield jameshadfield temporarily deployed to auspice-add-japanese-o1tazzzu5 April 7, 2020 22:11 Inactive
Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Emma!

This looks great but there are a some strings missing (e.g. all the sidebar.json strings are still in english). If you run npm run diff-lang -- ja then you'll be able to track which keys are missing etc 😄 Here's the current output:

npm run diff-lang -- ja

JA: comparing sidebar.json against the English translation
        Following keys need to be added:
                "Show confidence intervals"
        Following keys are identical to the English version & may need to be translated:
                "Dataset"
                "Date Range"
                "Color By"
                "Tree Options"
                "Layout"
                "rectangular"
                "radial"
                "unrooted"
                "clock"
                "Branch Length"
                "time"
                "divergence"
                "Branch Labels"
                "Search Strains"
                "Second Tree"
                "Map Options"
                "Geographic resolution"
                "Animation Speed"
                "Loop animation"
                "Animate cumulative history"
                "Panel Options"
                "Show tree"
                "Show map"
                "Show entropy"
                "Language"
                "Slow"
                "Medium"
                "Fast"
                "full"
                "grid"
JA: comparing translation.json against the English translation
        Following keys need to be added:
                "A full list of sequence authors is available via the TSV files below"
        Following keys are present but should be removed as they are no longer used:
                "A full list of sequence authors is available via the TSV files below."
        Following keys are identical to the English version & may need to be translated:
                "Built with"
                "Click to zoom out to parent clade"
                "Gaps"

@jameshadfield jameshadfield temporarily deployed to auspice-add-japanese-o1tazzzu5 April 8, 2020 06:30 Inactive
@yuryu yuryu requested a review from jameshadfield April 8, 2020 06:32
@yuryu
Copy link
Contributor Author

yuryu commented Apr 8, 2020

Thanks for reviewing! I added translations for these literals. Also, I needed to adjust the original text for "more" because numbers need to come after "more" in Japanese.

Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brill! Thanks for updating the other languages with the necessary changes 😄

Never thought translations like this would happen, this is really cool 💯
image

@jameshadfield jameshadfield merged commit 6c8ee54 into nextstrain:master Apr 8, 2020
@yuryu yuryu deleted the add-japanese branch April 8, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[i18n] Translate Auspice to Japanese
2 participants